tuhaihe opened a new pull request, #2040:
URL: https://github.com/apache/cloudberry/pull/2040
The Incubator releasecheck tool reports binary files in the 2.2.0-rc1 source
archive. Looking at each one, only two are avoidable.
gpMgmt/demo/gppkg/data/ held a .deb and an .rpm, and they are output of the
script sitting beside them: generate_sample_gppkg.sh writes them there in
buildNative and reads them back in buildGppkg. Anyone who needs them can run
the first step, which is what its README already describes, so they go.
The rest stay and are recorded instead:
- the sample.gppkg the gppkg behave suite installs, which has to be a real
package because the tests exercise package handling
- src/bin/pgevent/MSG00001.bin, which comes from PostgreSQL, is referenced
by pgmsgevent.rc, and is described by the README next to it. Cloudberry never
builds it: src/bin/Makefile only adds pgevent to SUBDIRS when PORTNAME is win32
Widening the check matters as much as the deletion. It looked at class,
jar, tar, tgz, zip, exe, dll, so, gz and bz2, so none of the files the tool
found would have tripped it, including the two removed here. It now covers
deb, rpm, gppkg and bin as well, with the two kept files allowlisted.
README.apache.md gains a section giving the reason for each allowlisted
file, and records the PAX Python API test data
(contrib/pax_storage/src/api/python3/test/test.file*). Those are PAX-format
fixtures read by paxpy_test.py, one per set of column types. Their names carry
no extension the check can match, so documenting them is all that is possible;
they are listed so the set is not invisible.
Checked by running the workflow's allowlist logic over the tree: with deb,
rpm, gppkg and bin added, every matching file is accounted for, and every
allowlist entry still exists.
Assisted-by: Claude Code
Backpatch-through: REL_2_STABLE
<!-- Thank you for your contribution to Apache Cloudberry (Incubating)! -->
Fixes #ISSUE_Number
### What does this PR do?
<!-- Brief overview of the changes, including any major features or fixes -->
### Type of Change
- [ ] Bug fix (non-breaking change)
- [ ] New feature (non-breaking change)
- [ ] Breaking change (fix or feature with breaking changes)
- [ ] Documentation update
### Breaking Changes
<!-- Remove if not applicable. If yes, explain impact and migration path -->
### Test Plan
<!-- How did you test these changes? -->
- [ ] Unit tests added/updated
- [ ] Integration tests added/updated
- [ ] Passed `make installcheck`
- [ ] Passed `make -C src/test installcheck-cbdb-parallel`
### Impact
<!-- Remove sections that don't apply -->
**Performance:**
<!-- Any performance implications? -->
**User-facing changes:**
<!-- Any changes visible to users? -->
**Dependencies:**
<!-- New dependencies or version changes? -->
### Checklist
- [ ] Followed [contribution
guide](https://cloudberry.apache.org/contribute/code)
- [ ] Added/updated documentation
- [ ] Reviewed code for security implications
- [ ] This PR contains AI-assisted code generation
- [ ] Requested review from [cloudberry
committers](https://github.com/orgs/apache/teams/cloudberry-committers)
### Additional Context
<!-- Any other information that would help reviewers? Remove if none -->
### CI Skip Instructions
<!--
To skip CI builds, add the appropriate CI skip identifier to your PR title.
The identifier must:
- Be in square brackets []
- Include the word "ci" and either "skip" or "no"
- Only use for documentation-only changes or when absolutely necessary
-->
---
<!-- Join our community:
- Mailing list:
[[email protected]](https://lists.apache.org/[email protected])
(subscribe: [email protected])
- Discussions: https://github.com/apache/cloudberry/discussions -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
