This is an automated email from the ASF dual-hosted git repository.
ostinru pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry-pxf.git
The following commit(s) were added to refs/heads/main by this push:
new 12ae4ec8 CI: propagate automation build failures (#159)
12ae4ec8 is described below
commit 12ae4ec8bc5499e83608f45cec72390083e03e8d
Author: Nikolay Antonov <[email protected]>
AuthorDate: Tue Sep 22 18:48:39 2026 +0500
CI: propagate automation build failures (#159)
Fix three issues that hid missing automation coverage or prevented tests
from running:
- Remove `|| true` from all 11 automation `make GROUP=...` invocations in
`run_tests.sh`. Compilation and other nonzero make failures now propagate to CI
instead of producing a false-green result with no Surefire reports.
Surefire already uses `testFailureIgnore=true`, so ordinary Java test
failures still allow report collection and are detected by the subsequent CI
result checks. Workflow artifact collection steps retain `if: always()`. Other
best-effort cleanup and diagnostic commands are unchanged.
- Add missing class-level `@WorksWithFDW` to `PxfFdwExtensionTest`.
- Stop overriding `JAVA_HOME` with Java 8 in `bench_prepare_env()`. Load
and performance tests now retain the Java 11 environment selected by the runner.
---
.../features/extension/PxfFdwExtensionTest.java | 2 ++
ci/docker/pxf-cbdb-dev/common/script/run_tests.sh | 23 +++++++++++-----------
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git
a/automation/src/test/java/org/apache/cloudberry/pxf/automation/features/extension/PxfFdwExtensionTest.java
b/automation/src/test/java/org/apache/cloudberry/pxf/automation/features/extension/PxfFdwExtensionTest.java
index 27f07510..6627b870 100644
---
a/automation/src/test/java/org/apache/cloudberry/pxf/automation/features/extension/PxfFdwExtensionTest.java
+++
b/automation/src/test/java/org/apache/cloudberry/pxf/automation/features/extension/PxfFdwExtensionTest.java
@@ -19,10 +19,12 @@ package
org.apache.cloudberry.pxf.automation.features.extension;
* under the License.
*/
+import annotations.WorksWithFDW;
import org.apache.cloudberry.pxf.automation.AbstractTestcontainersTest;
import org.apache.cloudberry.pxf.automation.applications.CloudberryApplication;
import org.testng.annotations.Test;
+@WorksWithFDW
public class PxfFdwExtensionTest extends AbstractTestcontainersTest {
private CloudberryApplication extensionDb;
diff --git a/ci/docker/pxf-cbdb-dev/common/script/run_tests.sh
b/ci/docker/pxf-cbdb-dev/common/script/run_tests.sh
index d7afb363..226825fd 100755
--- a/ci/docker/pxf-cbdb-dev/common/script/run_tests.sh
+++ b/ci/docker/pxf-cbdb-dev/common/script/run_tests.sh
@@ -235,36 +235,36 @@ base_test(){
export PATH="${GPHOME}/bin:${PATH}"
ensure_testuser_pg_hba
- make GROUP="hdfs" || true
+ make GROUP="hdfs"
save_test_reports "hdfs"
echo "[run_tests] GROUP=hdfs finished"
- make GROUP="hcfs" || true
+ make GROUP="hcfs"
save_test_reports "hcfs"
echo "[run_tests] GROUP=hcfs finished"
cleanup_hive_state
ensure_hive_tez_settings
ensure_yarn_vmem_settings
- make GROUP="hive" || true
+ make GROUP="hive"
save_test_reports "hive"
echo "[run_tests] GROUP=hive finished"
start_hbase
cleanup_hbase_state
- make GROUP="hbase" || true
+ make GROUP="hbase"
save_test_reports "hbase"
echo "[run_tests] GROUP=hbase finished"
- make GROUP="profile" || true
+ make GROUP="profile"
save_test_reports "profile"
echo "[run_tests] GROUP=profile finished"
- make GROUP="proxy" || true
+ make GROUP="proxy"
save_test_reports "proxy"
echo "[run_tests] GROUP=proxy finished"
- make GROUP="unused" || true
+ make GROUP="unused"
save_test_reports "unused"
echo "[run_tests] GROUP=unused finished"
}
@@ -356,15 +356,14 @@ feature_test(){
fi
# "features" and "gpdb" tags largely overlap; union them so each test
# runs once per USE_FDW mode instead of once per tag
- make GROUP="features,gpdb" $extra_args || true
+ make GROUP="features,gpdb" $extra_args
save_test_reports "$report_name"
echo "[run_tests] GROUP=features,gpdb $extra_args finished"
}
bench_prepare_env() {
export HADOOP_HEAPSIZE=${HADOOP_HEAPSIZE:-2048}
- export JAVA_HOME="${JAVA_HADOOP}"
- export PATH="${JAVA_HOME}/bin:${HADOOP_HOME}/bin:${PATH}"
+ export PATH="${HADOOP_HOME}/bin:${PATH}"
hdfs dfs -rm -r -f /tmp/pxf_automation_data
/gpdb-ud-scratch/tmp/pxf_automation_data >/dev/null 2>&1 || true
for scratch in /tmp/pxf_automation_data
/gpdb-ud-scratch/tmp/pxf_automation_data; do
@@ -382,14 +381,14 @@ bench_prepare_env() {
load_test(){
bench_prepare_env
- make GROUP="load" || true
+ make GROUP="load"
save_test_reports "load"
echo "[run_tests] GROUP=load finished"
}
performance_test(){
bench_prepare_env
- make GROUP="performance" || true
+ make GROUP="performance"
save_test_reports "performance"
echo "[run_tests] GROUP=performance finished"
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
