MisterRaindrop commented on PR #2022: URL: https://github.com/apache/cloudberry/pull/2022#issuecomment-5788421681
I don't think treating the whole [8000, 9000) range as unpinned is safe. The 8000-9999 range is reserved for development OIDs (including in-progress patches and forks), rather than for unpinned extension objects. A core catalog object may legitimately use an 8xxx OID during development and should still be treated as pinned. More importantly, this introduces an inconsistency with IsCatalogRelationOid(), which still treats every relation with relid < FirstUnpinnedObjectId (12000) as a system catalog. For example, a Yezzey relation with OID 8500 would become: IsPinnedObject(..., 8500) == false IsCatalogRelationOid(8500) == true So the object becomes droppable while still being classified as a system relation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
