yjhjstz commented on code in PR #2067:
URL: https://github.com/apache/cloudberry/pull/2067#discussion_r4146995131
##########
src/backend/gporca/libnaucrates/src/statistics/CFilterStatsProcessor.cpp:
##########
@@ -461,9 +461,6 @@ CFilterStatsProcessor::MakeHistHashMapConjFilter(
// scaling factor of the last predicate
scale_factors->Append(GPOS_NEW(mp) CDouble(last_scale_factor));
- GPOS_ASSERT(nullptr != scale_factors);
- CScaleFactorUtils::SortScalingFactor(scale_factors, true /* fDescending
*/);
Review Comment:
why remove this? scale_factors do sort in `SortScalingFactor`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
