Pearl1594 commented on a change in pull request #4329:
URL: https://github.com/apache/cloudstack/pull/4329#discussion_r565824268
##########
File path: tools/appliance/systemvmtemplate/scripts/install_systemvm_packages.sh
##########
@@ -70,20 +76,33 @@ function install_packages() {
radvd \
sharutils genisoimage aria2 \
strongswan libcharon-extra-plugins libstrongswan-extra-plugins
strongswan-charon strongswan-starter \
- virt-what open-vm-tools qemu-guest-agent hyperv-daemons
+ virt-what open-vm-tools qemu-guest-agent hyperv-daemons cloud-guest-utils \
+ apt-transport-https ca-certificates curl gnupg gnupg-agent
software-properties-common cloud-init
apt-get -y autoremove --purge
apt-get clean
apt-get autoclean
+ apt_clean
${apt_get} install links
+ curl -fsSL https://download.docker.com/linux/debian/gpg | sudo apt-key add -
+ apt-key fingerprint 0EBFCD88
+
#32 bit architecture support for vhd-util: not required for 32 bit template
if [ "${arch}" != "i386" ]; then
dpkg --add-architecture i386
apt-get update
${apt_get} install libuuid1:i386 libc6:i386
+
+ add-apt-repository \
+ "deb [arch=amd64] https://download.docker.com/linux/debian \
+ $(lsb_release -cs) \
+ stable"
+ apt-get update
+ ${apt_get} install docker-ce docker-ce-cli containerd.io
Review comment:
@weizhouapache I completely understand your concerns. However, the basic
intent of moving to systemVM template was that we could leverage the already
registered template, thus removing the need to register a new template for CKS.
We've ensured that VRs and systemVMs will not be affected by these new packages
installed. In case the concern is about the template size, it's increased by
500MB and have incorporated your PR
https://github.com/apache/cloudstack/pull/3900 for growing / resizing the root
disk partition during boot up to a predefined / provided disk size. We could
also probably discuss this on the mailing list to get a feedback from a wider
audience and incorporate and test all cases to ensure that there aren't any
adverse effects of these changes.. Thanks @weizhouapache
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
