sureshanaparti commented on a change in pull request #4561:
URL: https://github.com/apache/cloudstack/pull/4561#discussion_r566849808
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUnPlugNicCommandWrapper.java
##########
@@ -82,4 +87,22 @@ public Answer execute(final UnPlugNicCommand command, final
LibvirtComputingReso
}
}
}
+
Review comment:
could see same methods `getVlanIdFromBridgeName()` and
`shouldDeleteBridge()` defined/implemented in the classes -
LibvirtMigrateCommandWrapper, LibvirtStopCommandWrapper,
LibvirtUnPlugNicCommandWrapper.
can you defined these in a common class (may be some util class) and use
them across.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
