DaanHoogland commented on pull request #3915: URL: https://github.com/apache/cloudstack/pull/3915#issuecomment-772314067
> > code looks good but I am missing handling of redundant state. Do we need more code to check if it is an rvr and set it to passive if it is? @ggoodrich-ipp cc @rhtyd @weizhouapache > > Hi @DaanHoogland > I do not think it matters if it is an RVR or not. If a VR is thought to have been powered-on OOB (occurs in scenario in description), this checks that it can communicate with the VR and if it cannot, it reboots it to get it to a clean/manageable state. > > If it was a RVR or not, the mgmt servers should still be able to communicate with the VR. If it cannot, then we need to restart the VR. If it is part of a RVR setup, it should come up and join the VRRP setup. Hm, so how about these, scenario 1: - one of a set of RVR goes down - ACS creates a new one - VR comes up it now matters wether this one is active or passive for the functionality of the over all RVR. scenario 2: - The complete RVR goes down - the passive comes up there is no functionality in general ACS would create a new VR and if an old VR comes up there is more to do then just check for communication, as @weizhouapache is suggesting: > > No, rebooting a VR (if not in a RVR setup) is disruptive to the networking of any VMs using it. This only reboots it if we must - when we can't communicate with it. > > @Slair1 yes. > but, if check router return true, it does not mean the VR which serves as gateway, dhcp/dns server and userdata server, is working well. > rebooting VR will cause few minutes downtime (depends on vm counts and network configs) of the network, but it will avoid some issues which might happen caused by misconfigurations after VR OOB start. the network will be more stable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
