DaanHoogland commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r574379685
##########
File path:
vmware-base/src/main/java/com/cloud/hypervisor/vmware/util/VmwareHelper.java
##########
@@ -549,12 +549,6 @@ public static void
setBasicVmConfig(VirtualMachineConfigSpec vmConfig, int cpuCo
cpuInfo.setReservation((long)cpuReservedMhz);
vmConfig.setCpuAllocation(cpuInfo);
- if (cpuSpeedMHz != cpuReservedMhz) {
- vmConfig.setCpuHotAddEnabled(true);
- }
- if (memoryMB != memoryReserveMB) {
- vmConfig.setMemoryHotAddEnabled(true);
- }
Review comment:
not sure if that is needed and/or suffices; How about when people want
to hot-add and don't care about reservation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
