harikrishna-patnala commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r575018287
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -210,18 +213,19 @@ protected Answer copyObject(DataObject srcData,
DataObject destData, Host destHo
* @param dataTO Dest data store TO
* @return dataTO including fullCloneFlag, if provided
*/
- protected DataTO addFullCloneFlagOnVMwareDest(DataTO dataTO) {
+ protected DataTO
addFullCloneAndDiskprovisiongStrictnessFlagOnVMwareDest(DataTO dataTO) {
if (dataTO != null &&
dataTO.getHypervisorType().equals(Hypervisor.HypervisorType.VMware)){
DataStoreTO dataStoreTO = dataTO.getDataStore();
if (dataStoreTO != null && dataStoreTO instanceof
PrimaryDataStoreTO){
PrimaryDataStoreTO primaryDataStoreTO = (PrimaryDataStoreTO)
dataStoreTO;
- Boolean value =
CapacityManager.VmwareCreateCloneFull.valueIn(primaryDataStoreTO.getId());
- primaryDataStoreTO.setFullCloneFlag(value);
+
primaryDataStoreTO.setFullCloneFlag(CapacityManager.VmwareCreateCloneFull.valueIn(primaryDataStoreTO.getId()));
+
primaryDataStoreTO.setDiskProvisioningStrictnessFlag(storageManager.DiskProvisioningStrictness.valueIn(primaryDataStoreTO.getId()));
}
Review comment:
DiskProvisioningStrictness setting is of zone scope, please use zone id
here, instead of primaryDataStoreTO.getId()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
