DaanHoogland commented on a change in pull request #4630:
URL: https://github.com/apache/cloudstack/pull/4630#discussion_r575648160
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java
##########
@@ -139,6 +140,10 @@ VirtualMachineTO implement(VirtualMachineProfile vm,
VirtualMachineTO to, long c
details.put(VmDetailConstants.NIC_ADAPTER,
VirtualEthernetCardType.E1000.toString());
}
}
+ if(vm.getVirtualMachine() instanceof VMInstanceVO){
+ VMInstanceVO vmInstanceVO =(VMInstanceVO)
vm.getVirtualMachine();
+
to.setEnableDynamicallyScaleVm(vmInstanceVO.isDynamicallyScalable());
Review comment:
bit of background guys: The VmwareVMImplementer is a worker class that
is part of the VmwareGuru, and is meant to reduce the complexity by extracting
the deploy and start code. It would be good to put shared code in a
VmwareGuruUtilities class to prevent duplication. I can imagine that setting
flags can be done on implement as well as on restart/migrate or other methods.
I might be guilty of this redundancy, but take care that setting might happen
twice in one scenario but twice in another ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
