rhtyd commented on a change in pull request #4604:
URL: https://github.com/apache/cloudstack/pull/4604#discussion_r578392476
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -621,11 +622,13 @@ public VMSnapshotResponse
createVMSnapshotResponse(VMSnapshot vmSnapshot) {
vmSnapshotResponse.setDisplayName(vmSnapshot.getDisplayName());
UserVm vm = ApiDBUtils.findUserVmById(vmSnapshot.getVmId());
if (vm != null) {
- vmSnapshotResponse.setVirtualMachineid(vm.getUuid());
+ vmSnapshotResponse.setVirtualMachineId(vm.getUuid());
+
vmSnapshotResponse.setVirtualMachineName(Strings.isNullOrEmpty(vm.getDisplayName())
? vm.getHostName() : vm.getDisplayName());
Review comment:
LGTM - we need one check if for normal user/account it leaks the
internal hostname (is hostname the i-x-y-VM?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
