sureshanaparti commented on a change in pull request #4300:
URL: https://github.com/apache/cloudstack/pull/4300#discussion_r580209328
##########
File path:
services/console-proxy/server/src/main/java/com/cloud/consoleproxy/vnc/NoVncClient.java
##########
@@ -62,6 +69,27 @@ public void connectTo(String host, int port) throws
UnknownHostException, IOExce
setStreams();
}
+ public void connectToWebSocket(String websocketUrl, Session session)
throws URISyntaxException {
+ webSocketReverseProxy = new WebSocketReverseProxy(new
URI(websocketUrl), session);
+ webSocketReverseProxy.connect();
+ }
+
+ public boolean isVncOverWebSocketConnection() {
+ return webSocketReverseProxy != null;
+ }
+
Review comment:
Non websocket connections, will cause NPE for the below methods. Either
add a comment here to use these methods for _isVncOverWebSocketConnection()_
true, or explicitly add a check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
