GutoVeronezi opened a new pull request #4722:
URL: https://github.com/apache/cloudstack/pull/4722


   ### Description
   When ACS is deploying a VM, it defines a minimum memory|CPU to the VM based 
on a calculation through the overprovisioning (defined mem|cpu speed / 
overprovisioning factor); Therefore, it will define a range of memory|CPU, even 
if it does not use scalable (dynamic) service offerings. 
   
   This PR intends to externalize 2 cluster's configurations to allow operators 
to decide if they want the minimum memory|CPU to be different from the 
allocated value when the overprovisioning's configurations are different than 
`1`. 
   
   When we set the overprovisioning factor, it means that we (as operators) are 
willing to allocate more virtual resources than the physical ones. This is 
interesting when the hypervisor has optimization techniques such as the KVM 
ones for optimizing the allocation of common blocks among running virtual 
machines (Kernel Samepage Merging - KSM). Therefore, we do not need to reduce 
the minimum amount of memory that the VM must receive when the overprovisioning 
is higher than one. This is important for public cloud environments, where such 
definition can be perceived by final users.
   
   ### Types of changes
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   - [ ] Major
   - [x] Minor
   
   ### How Has This Been Tested?
   It has been tested locally in a test lab.
   
   1. I had created VM and observed the `dumpxml`.
   
   2. When I was using the configuration as `true`, it kept the same behavior 
(allocated memory <> currentMemory).
   
![image](https://user-images.githubusercontent.com/38945620/108745447-d8640d80-7519-11eb-989b-3ee27887c2b5.png)
   
   3. When I was using the configuration as `false`, it took the current memory 
equals the allocated memory.
   
![image](https://user-images.githubusercontent.com/38945620/108745526-f598dc00-7519-11eb-83b6-cb29c0699aab.png)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to