[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #4639: cks: use HttpsURLConnection for checking api server

[GitBox]

DaanHoogland commented on a change in pull request #4639:
URL: https://github.com/apache/cloudstack/pull/4639#discussion_r581042829



##########
File path: 
plugins/integrations/kubernetes-service/src/main/java/com/cloud/kubernetes/cluster/utils/KubernetesClusterUtil.java
##########
@@ -218,7 +221,10 @@ public static boolean 
isKubernetesClusterServerRunning(final KubernetesCluster k
         boolean k8sApiServerSetup = false;
         while (System.currentTimeMillis() < timeoutTime) {
             try {
-                String versionOutput = IOUtils.toString(new 
URL(String.format("https://%s:%d/version";, ipAddress, port)), 
StringUtils.getPreferredCharset());
+                URL url = new URL(String.format("https://%s:%d/version";, 
ipAddress, port));
+                HttpsURLConnection con = 
(HttpsURLConnection)url.openConnection();

Review comment:
       and get more static analysis reports as issues?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org