GabrielBrascher commented on pull request #4212: URL: https://github.com/apache/cloudstack/pull/4212#issuecomment-789912301
Code has been updated reverting the change to allow choosing between Stop or ForceStop. It turns out that the implementation got a bit tricky when HA management calls a VM `Stop` at the maintenance workflow. For now, keeping only VM `ForceStop`. Fitting the "graceful" Stop into the current maintenance workflow might be a good enhancement for another PR, but for now, keeping the strategy feature as it is: 1. The default strategy is 'Error', preventing maintenance in such a case 2. Choose 'Migration' strategy to migrate away VMs running on local storage 3. To force-stop VMs, choose the 'ForceStop' strategy Manual tests are looking good. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
