Pearl1594 opened a new pull request #4829:
URL: https://github.com/apache/cloudstack/pull/4829


   ### Description
   
   This PR fixes the issue pertaining to volume resize on VMWare for deploy 
as-is templates. VMware deploy as-is templates are those that are deployed as 
per the specification in the imported OVF. Hence override root disk size will 
not be adhered to for such templates. Moreover, when we deploy VMs in stopped 
state and resize the volume, the root disk doesn't get resized but the volume 
size is merely updated in the DB.
   This PR also includes the following (for deploy as-is templates):
   - Disables overriding root disk size during VM deployment on the UI
   - Disables selection of compute offerings with root disk size specified, at 
the time of deployment
   - Provided users with the option to deploy VM is stopped state via UI (so as 
to give an option to users to resize the volumes before starting the VM)
   
   <!--- 
*********************************************************************************
 -->
   <!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE 
DOCUMENTATION. -->
   <!--- PLEASE PUT AN 'X' in only **ONE** box -->
   <!--- 
*********************************************************************************
 -->
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [X] Bug fix (non-breaking change which fixes an issue)
   - [ ] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Bug Severity
   
   - [ ] BLOCKER
   - [X] Critical
   - [ ] Major
   - [ ] Minor
   - [ ] Trivial
   
   
   ### Screenshots (if appropriate):
   
   
   ### How Has This Been Tested?
   #### Prior to the fix:
   Deployed a VM in stopped state, resized volume from 3GB to 8GB
   
![image](https://user-images.githubusercontent.com/10495417/111328544-57b9ac80-8694-11eb-9d66-1312b3740c9a.png)
   
   While the UI shows that the Volume is resized,  the root volume inside the 
VM doesn't seem to have gotten resized:
   
![image](https://user-images.githubusercontent.com/10495417/111328782-90598600-8694-11eb-9dce-b867c43604a4.png)
   
   #### Post fix
   Deployed a VM in stopped state, resized the volume from 3GB to 8GB
   
![image](https://user-images.githubusercontent.com/10495417/111328916-aff0ae80-8694-11eb-9c3c-a38dd6a10146.png)
   
   
![image](https://user-images.githubusercontent.com/10495417/111328948-b717bc80-8694-11eb-82a6-ba925cc0afd2.png)
   
   Notice that the volume size as shown in the UI complies with the value 
inside the VM
   
   
   <!-- Please read the 
[CONTRIBUTING](https://github.com/apache/cloudstack/blob/master/CONTRIBUTING.md)
 document -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to