sureshanaparti commented on a change in pull request #4829:
URL: https://github.com/apache/cloudstack/pull/4829#discussion_r596631148
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -5266,6 +5270,16 @@ public UserVm createVirtualMachine(DeployVMCmd cmd)
throws InsufficientCapacityE
throw new InvalidParameterValueException("Unable to use template "
+ templateId);
}
+ ServiceOfferingJoinVO svcOffering =
serviceOfferingJoinDao.findById(serviceOfferingId);
+
Review comment:
@Pearl1594 is it possible to move all the checks after
`template.isDeployAsIs()` to a separate if stmt (instead calling
"template.isDeployAsIs()" multiple times)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
