GabrielBrascher commented on a change in pull request #4776:
URL: https://github.com/apache/cloudstack/pull/4776#discussion_r600787824
##########
File path: server/src/main/java/com/cloud/api/query/dao/UserVmJoinDaoImpl.java
##########
@@ -78,6 +81,8 @@
private UserDao _userDao;
@Inject
private NicExtraDhcpOptionDao _nicExtraDhcpOptionDao;
+ @Inject
+ UserStatisticsDao _userStatsDao;
Review comment:
I don't want to sound repetitive and I would not block a PR due to `_`,
in any circumstance. But I would really appreciate it if you could remove `_`
from any added variable :slightly_smiling_face:
##########
File path: server/src/main/java/com/cloud/api/ApiResponseHelper.java
##########
@@ -394,6 +397,8 @@
private VMSnapshotDao vmSnapshotDao;
@Inject
private BackupOfferingDao backupOfferingDao;
+ @Inject
+ private UserStatisticsDao _userStatsDao;
Review comment:
@ravening can you please remove the underscore `_` at the beginning of
the variable name?
Many variables on the codebase have `_` at the beginning but it is not
aligned with the [Java variable naming
convention](https://docs.oracle.com/javase/tutorial/java/nutsandbolts/variables.html).
According to [Java variable naming
convention](https://docs.oracle.com/javase/tutorial/java/nutsandbolts/variables.html):
> A similar convention exists for the underscore character; while it's
technically legal to begin your variable's name with "_", this practice is
discouraged. White space is not permitted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
