rhtyd commented on a change in pull request #4773:
URL: https://github.com/apache/cloudstack/pull/4773#discussion_r607619645
##########
File path: tools/marvin/marvin/config/test_data.py
##########
@@ -928,6 +928,16 @@
"ostype": "CentOS 5.6 (64-bit)",
"mode": 'HTTP_DOWNLOAD',
},
+ "iso3": {
+ "displaytext": "Test ISO 3",
+ "name": "ISO 3",
+ "url": "http://people.apache.org/~tsp/dummy.iso";,
Review comment:
@slavkap does your newly added test work with the fix?
Yes, that's a practice we should avoid if/when possible. For running tests
with blueorangutan/Trillian, we patch the test_data.py file
https://github.com/shapeblue/Trillian/blob/master/Ansible/roles/marvin/templates/test_data.py.j2
So anytime anyone adds invalid data, we manually patch it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
