wido commented on pull request #4878: URL: https://github.com/apache/cloudstack/pull/4878#issuecomment-815532753
> @wido We already have the API `resizeVolume`, which is designed to scale the root disk as well as data disks, and it works with VMs in `stopped` or `running` states. > > This API `scaleVirtualMachine` was first designed to scale computing resources (`memory`, `cpuNumber` and `cpuSpeed`). I think we should not mix these two concepts here. After reading the code and comments from @GabrielBrascher I understand this code only works with custom service offerings, correct? If so, please disregard my comments. Otherwise, with PR #4341 merged we now have the option to make the root disk size a condition of the service offering. Thus when changing the offering one needs to make sure that the root disk is also resized according to the new offering. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
