DaanHoogland commented on pull request #4493: URL: https://github.com/apache/cloudstack/pull/4493#issuecomment-816520958
I think trying to attach disk during discovery is a bug. It can give serious errors if the disks were attached to another VM before recovery. We should document that this behaviour had unexpected side effects and at best make an optional attempt to find the disks and attach them if explicitly requested by the user. The code I see here is only doing the detaching (unconditionally and independent of hypervisor), which lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
