Pearl1594 commented on a change in pull request #4551:
URL: https://github.com/apache/cloudstack/pull/4551#discussion_r613819052
##########
File path:
engine/storage/datamotion/src/main/java/org/apache/cloudstack/storage/motion/AncientDataMotionStrategy.java
##########
@@ -392,15 +405,16 @@ protected Answer copyVolumeBetweenPools(DataObject
srcData, DataObject destData)
return answer;
}
} catch (Exception e) {
- if (imageStore.exists(objOnImageStore)) {
+ if (objOnImageStore != null) {
objOnImageStore.processEvent(Event.OperationFailed);
imageStore.delete(objOnImageStore);
Review comment:
It makes sense to delete the volume on secondary store on failure. Will
add that - needs testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
