mike-tutkowski commented on a change in pull request #4918:
URL: https://github.com/apache/cloudstack/pull/4918#discussion_r614575637
##########
File path: server/src/main/java/com/cloud/server/StatsCollector.java
##########
@@ -1020,14 +1020,22 @@ protected void runInContext() {
if (answer != null && answer.getResult()) {
storagePoolStats.put(pool.getId(),
(StorageStats)answer);
+ boolean poolNeedsUpdating = false;
// Seems like we have dynamically updated the pool
size since the prev. size and the current do not match
- if (pool.getCapacityBytes() !=
((StorageStats)answer).getCapacityBytes() ||
- pool.getUsedBytes() !=
((StorageStats)answer).getByteUsed()) {
-
pool.setCapacityBytes(((StorageStats)answer).getCapacityBytes());
- if
(pool.getStorageProviderName().equalsIgnoreCase(DataStoreProvider.DEFAULT_PRIMARY))
{
- pool.setUsedBytes(((StorageStats)
answer).getByteUsed());
- pool.setUpdateTime(new Date());
+ if (_storagePoolStats.get(poolId) != null &&
_storagePoolStats.get(poolId).getCapacityBytes() !=
((StorageStats)answer).getCapacityBytes()) {
+ if (((StorageStats)answer).getCapacityBytes()
> 0) {
+
pool.setCapacityBytes(((StorageStats)answer).getCapacityBytes());
+ poolNeedsUpdating = true;
+ } else {
+ s_logger.warn("Received 0 capacity for
pool ID " + poolId);
}
+ }
+ if (pool.getUsedBytes() !=
((StorageStats)answer).getByteUsed() &&
pool.getStorageProviderName().equalsIgnoreCase(DataStoreProvider.DEFAULT_PRIMARY)
&& !pool.isManaged()) {
Review comment:
That's a good point about managed-storage providers not using
DefaultPrimary. Each of these storage providers probably provides its own
plug-in.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
