rhtyd commented on a change in pull request #4907:
URL: https://github.com/apache/cloudstack/pull/4907#discussion_r614647748
##########
File path: api/src/main/java/com/cloud/template/TemplateApiService.java
##########
@@ -56,9 +56,9 @@
VirtualMachineTemplate prepareTemplate(long templateId, long zoneId, Long
storageId);
- boolean detachIso(long vmId);
+ boolean detachIso(long vmId, boolean forced);
Review comment:
it's passed from API layer - which handles this and ensures that this is
either false or true. Furthermore, `boolean` is a primitive type and cannot be
`null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]