GabrielBrascher commented on a change in pull request #4707:
URL: https://github.com/apache/cloudstack/pull/4707#discussion_r617768243
##########
File path: server/src/main/java/org/apache/cloudstack/ha/HAManagerImpl.java
##########
@@ -298,14 +308,10 @@ public Boolean isVMAliveOnHost(final Host host) throws
Investigator.UnknownVM {
final HAConfig haConfig = haConfigDao.findHAResource(host.getId(),
HAResource.ResourceType.Host);
if (haConfig != null) {
if (haConfig.getState() == HAConfig.HAState.Fenced) {
- if (LOG.isDebugEnabled()){
- LOG.debug("HA: Host is fenced " + host.getId());
- }
+ LOG.debug(String.format("HA: Host [%s] is fenced.",
host.getId()));
Review comment:
I was wondering if some of the HA messages should be logged as DEBUG or
INFO levels. I think that there are some quite important information to raise
for ADMINs regardless of they wanting a debug, info, or trace log level.
For example, when a host gets fenced.
What do you think @DaanHoogland @GutoVeronezi? Does that make sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
