GabrielBrascher commented on a change in pull request #4705:
URL: https://github.com/apache/cloudstack/pull/4705#discussion_r619205247
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHAVMActivityChecker.java
##########
@@ -52,11 +52,14 @@ public Boolean checkingHB() {
cmd.add("-t", String.valueOf(String.valueOf(System.currentTimeMillis()
/ 1000)));
cmd.add("-d", String.valueOf(suspectTimeInSeconds));
OutputInterpreter.OneLineParser parser = new
OutputInterpreter.OneLineParser();
+
String result = cmd.execute(parser);
- LOG.debug("KVMHAVMActivityChecker pool: " + nfsStoragePool._poolIp);
- LOG.debug("KVMHAVMActivityChecker result: " + result);
- LOG.debug("KVMHAVMActivityChecker parser: " + parser.getLine());
- if (result == null && parser.getLine().contains("DEAD")) {
+ String parsedLine = parser.getLine();
+
+ LOG.debug(String.format("Checking HB with KVMHAVMActivityChecker
[{command=\"%s\", result: \"%s\", log: \"%s\", pool: \"%s\"}].",
cmd.toString(), result, parsedLine, nfsStoragePool._poolIp));
Review comment:
Never mind, it is the Heart Beat, right?
I would suggest a different name then as HB might not mean much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
