Spaceman1984 commented on pull request #4859: URL: https://github.com/apache/cloudstack/pull/4859#issuecomment-826547024
> Tested all calls manually except LoadBalancingRulesManagerImpl#applyLBHealthCheckPolicy, I'm not sure how to. @rhtyd. > Seems like I need Netscaler infra. > > Other than that, no issues found. I picked up an issue with one of the calls, it doesn't break anything, I just feel that the check is not needed in this particular situation. In AccountManagerImpl#createApiKeyAndSecretKey - this method is called the first time the management server starts up and the baremetal system user doesn't exist. The checkAccess method then checks if the system user is allowed to access the baremetal system user account, which always returns true for the system account. API Command Name | Method | Owner | Different User ----|----|----|---- updateVolume | VolumeApiServiceImpl # updateVolume | Pass | Pass destroyVirtualMachine | VolumeApiServiceImpl # detachVolumeViaDestroyVM | Pass | Pass createSnapshot | VolumeApiServiceImpl # takeSnapshot | Pass | Pass migrateVolume | VolumeApiServiceImpl # migrateVolume | Pass | Pass N/A - called to create baremetal user the first time the management server starts up. - I don't believe we need this check| AccountManagerImpl#createApiKeyAndSecretKey | N/A | N/A createLBStickinessPolicy | LoadBalancingRulesManagerImpl#applyLBStickinessPolicy | Pass | Pass createLBHealthCheckPolicy | LoadBalancingRulesManagerImpl#applyLBHealthCheckPolicy | skipped | skipped createTemplate | TemplateManagerImpl#createPrivateTemplate | Pass | Pass updateSnapshotPolicy | SnapshotManagerImpl#updateSnapshotPolicy | Pass | Pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
