DaanHoogland commented on a change in pull request #4960:
URL: https://github.com/apache/cloudstack/pull/4960#discussion_r623820604
##########
File path: engine/schema/src/main/java/com/cloud/user/AccountVO.java
##########
@@ -188,7 +188,7 @@ public long getAccountId() {
@Override
public String toString() {
- return new
StringBuilder("Acct[").append(uuid).append("-").append(accountName).append("]").toString();
+ return String.format("Account {\"id\": %s, \"name\": \"%s\", \"uuid\":
\"%s\"}", id, accountName, uuid);
Review comment:
Though I do agree this is an improvement it might break ecosystem
scripts for some. How about
```suggestion
return String.format("Acct["%s-%s] -- Account {\"id\": %s, \"name\":
\"%s\", \"uuid\": \"%s\"}",uuid ,accountName, id, accountName, uuid);
```
to have some more guarantee on backwards compatibility?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
