GabrielBrascher commented on a change in pull request #4954:
URL: https://github.com/apache/cloudstack/pull/4954#discussion_r625230123
##########
File path:
utils/src/test/java/org/apache/cloudstack/utils/mailing/SMTPMailSenderTest.java
##########
@@ -0,0 +1,618 @@
+/*
+ * Copyright 2021 The Apache Software Foundation.
Review comment:
@DaanHoogland that's a good question.
This header difference is a bit confusing especially due to the fact that
Apache license 2.0 adds the Copyright, but at the same time, the documentation
regarding Apache's source code do say to **not add** the copyright.
I think that @GutoVeronezi is used to work with
https://www.apache.org/licenses/LICENSE-2.0 and then added it on his PRs. I
have nothing against it; however, Apache is very clear about how to proceed in
terms of [Source File Headers for Code Developed at the
ASF](https://www.apache.org/legal/src-headers.html#headers), which I think fits
on any CloudStack source header, regardless of who donated the contribution to
the Apache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
