sureshanaparti commented on a change in pull request #4953:
URL: https://github.com/apache/cloudstack/pull/4953#discussion_r626320302
##########
File path:
api/src/main/java/org/apache/cloudstack/api/command/user/vpn/CreateVpnCustomerGatewayCmd.java
##########
@@ -92,6 +92,13 @@
description = "create site-to-site VPN customer gateway for the
project", since = "4.6")
private Long projectId;
+ @Parameter(name = ApiConstants.SPLIT_CONNECTIONS, type =
CommandType.BOOLEAN, required = false, description = "For IKEv2, whether to
split multiple right subnet cidrs into multiple connection statements.")
+ private Boolean splitConnections;
+
+ @Parameter(name = ApiConstants.IKE_VERSION, type = CommandType.STRING,
required = false, description = "Which IKE Version to use, one of ike
(autoselect), ikev1, or ikev2. " +
+ "Connections marked with 'ike' will use 'ikev2' when initiating,
but accept any protocol version when responding. Defaults to ike")
+ private String ikeVersion;
+
Review comment:
@Pearl1594 add _since_ to both parameters, and validator for ike version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
