sureshanaparti commented on a change in pull request #4644:
URL: https://github.com/apache/cloudstack/pull/4644#discussion_r626502317
##########
File path:
plugins/storage/volume/default/src/main/java/org/apache/cloudstack/storage/datastore/driver/CloudStackPrimaryDataStoreDriverImpl.java
##########
@@ -211,10 +213,22 @@ public void createAsync(DataStore dataStore, DataObject
data, AsyncCompletionCal
}
}
+ private boolean commandCanBypassHostMaintenance(DataObject data) {
+ if (DataObjectType.VOLUME.equals(data.getType())) {
+ Volume volume = (Volume)data;
+ if (volume.getInstanceId() != null) {
+ VMInstanceVO vm = vmDao.findById(volume.getInstanceId());
+ return vm != null &&
(VirtualMachine.Type.SecondaryStorageVm.equals(vm.getType()) ||
+ VirtualMachine.Type.ConsoleProxy.equals(vm.getType()));
+ }
+ }
+ return false;
+ }
+
Review comment:
@shwstppr Is bypass host maintenance applicable for volumes in managed
storage as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
