GutoVeronezi commented on a change in pull request #4575:
URL: https://github.com/apache/cloudstack/pull/4575#discussion_r628269339



##########
File path: 
server/src/main/java/com/cloud/resource/RollingMaintenanceManagerImpl.java
##########
@@ -537,7 +539,7 @@ private boolean isMaintenanceScriptDefinedOnHost(Host host, 
List<HostSkipped> ho
                 answer = agentManager.send(host.getId(), cmd);
             } catch (AgentUnavailableException | OperationTimedoutException e) 
{
                 // Agent may be restarted on the scripts - continue polling 
until it is up
-                String msg = "Cannot send command to host: " + host.getId() + 
", waiting " + pingInterval + "ms - " + e.getMessage();
+                String msg = String.format("Cannot send command to %s, waiting 
%sms - %s", host, pingInterval, e.getMessage());
                 s_logger.warn(msg);

Review comment:
       Pass exception as parameter.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to