weizhouapache commented on pull request #4378:
URL: https://github.com/apache/cloudstack/pull/4378#issuecomment-836279756
> Tested on VMware (single cluster, 2x ESXi hosts), **worked fine for both
user and systemvms**.
>
> Suggestion for small UI improvement to not show `NaN GB`:
>
> ```
> --- a/ui/src/views/compute/MigrateWizard.vue
> +++ b/ui/src/views/compute/MigrateWizard.vue
> @@ -45,7 +45,9 @@
> v-else />
> </div>
> <div slot="memused" slot-scope="record">
> - {{ record.memoryused | byteToGigabyte }} GB
> + <span v-if="record.memoryused | byteToGigabyte">
> + {{ record.memoryused | byteToGigabyte }} GB
> + </span>
> </div>
> <div slot="memoryallocatedpercentage" slot-scope="record">
> {{ record.memoryallocatedpercentage }}
> ```
>
> Also, in UI should we hide/disable autoselect when there are no suitable
hosts found or if all hosts require storage migration? @weizhouapache
@shwstppr cool, thanks. good ideas !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
