DaanHoogland commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r629136908
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/resource/VmwareResource.java
##########
@@ -2905,7 +2905,7 @@ private void tearDownVm(VirtualMachineMO vmMo) throws
Exception {
int getReservedMemoryMb(VirtualMachineTO vmSpec) {
if
(vmSpec.getDetails().get(VMwareGuru.VmwareReserveMemory.key()).equalsIgnoreCase("true"))
{
-
if(!vmSpec.getDetails().get(VmDetailConstants.RAM_RESERVATION).equals("0.0")){
+ if(vmSpec.getDetails().get(VmDetailConstants.RAM_RESERVATION) !=
null &&
!vmSpec.getDetails().get(VmDetailConstants.RAM_RESERVATION).equals("0.0")){
Review comment:
how about
```suggestion
if(!"0.0".equals(vmSpec.getDetails().get(VmDetailConstants.RAM_RESERVATION))){
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
