sureshanaparti commented on a change in pull request #4922:
URL: https://github.com/apache/cloudstack/pull/4922#discussion_r629403133



##########
File path: api/src/main/java/org/apache/cloudstack/api/ApiConstants.java
##########
@@ -821,7 +821,7 @@
     public static final String SEMANTIC_VERSION = "semanticversion";
     public static final String KUBERNETES_VERSION_ID = "kubernetesversionid";
     public static final String KUBERNETES_VERSION_NAME = 
"kubernetesversionname";
-    public static final String MASTER_NODES = "masternodes";
+    public static final String PRIMARY_NODES = "primarynodes";

Review comment:
       > @sureshanaparti Please use Leader instead of primary to follow the 
kubernetes paradigm
   
   @davidjumani control nodes seems to be appropriate, is used for the 
kubernetes master nodes.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to