rhtyd commented on a change in pull request #4966:
URL: https://github.com/apache/cloudstack/pull/4966#discussion_r629522553
##########
File path: api/src/main/java/com/cloud/vm/NicProfile.java
##########
@@ -430,16 +430,6 @@ public void deallocate() {
@Override
public String toString() {
- return new StringBuilder("NicProfile[").append(id)
- .append("-")
- .append(vmId)
- .append("-")
- .append(reservationId)
- .append("-")
- .append(iPv4Address)
- .append("-")
- .append(broadcastUri)
- .append("]")
- .toString();
+ return String.format("NicProfile {\"id\": %s, \"vmId\": %s,
\"reservationId\": \"%s\", \"iPv4Address\": \"%s\", \"broadcastUri\": \"%s\"}",
id, vmId, reservationId, iPv4Address, broadcastUri);
Review comment:
@GutoVeronezi why are you converting them into hand-written json?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
