GutoVeronezi commented on pull request #4966:
URL: https://github.com/apache/cloudstack/pull/4966#issuecomment-837061808
> @GutoVeronezi you've submitted many PRs which are the same class of PRs
around log improvements and refactorings and changing the resource/vo/object
`toString()` that returns hand-written json and add inconsistency across other
VOs/objects/... Why is that? Are the json output from log statements consumed
somewhere?
>
> Can you club all such PRs into a single PR with separate/individual
commits? They make it difficult to review and test individually and take a lot
of time and resources from reviewers and BO/lab.
@rhtyd
Most of `toString()` implementations uses a simple hyphen (`-`) to separete
values, but what `NicProfile[1-2-3-192.168.0.1-...]` means? Operators get
confused and need to open the code to know what each value means. Moreover, if
a string contains a hyphen, it will print as an separator and can confuse much
more the operator.
JSON was chosen because it is an easy format to read key-value pairs.
`NicProfile {"id": 1, "vmId": 2, "reservationId": "3", "iPv4Address":
"192.168.0.1", "broadcastUri": "..."}` tells much more than a simple `-----`.
But that is not the focus of the PR. The focus is improve logging of these
classes, as they do not supply an appropriate context to make the operation
feasible.
About join all this PRs in only one (separated in commits):
Each PR is separted by context. Each one has their own peculiarity. Each
peaculiarity refactored is separated by commits. Join this all in a single
commit will make it even more difficult to review, as there will be a lot of
changes without pontual descriptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
