nvazquez commented on a change in pull request #5006:
URL: https://github.com/apache/cloudstack/pull/5006#discussion_r632487954



##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -2521,6 +2521,13 @@ public UserVm updateVirtualMachine(UpdateVMCmd cmd) 
throws ResourceUnavailableEx
         String extraConfig = cmd.getExtraConfig();
 
         UserVmVO vmInstance = _vmDao.findById(cmd.getId());
+        if (details.size() > 0) {

Review comment:
       Maybe `MapUtils.isNotEmpty(details)` to prevent possible NPE?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to