GutoVeronezi commented on a change in pull request #5012:
URL: https://github.com/apache/cloudstack/pull/5012#discussion_r633603256
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java
##########
@@ -1001,6 +1030,11 @@ public String toString() {
if(_discard != null && _discard != DiscardType.IGNORE) {
diskBuilder.append("discard='" + _discard.toString() + "'
");
}
+
+ if(ioDriver != null) {
+ diskBuilder.append("io='" + ioDriver + "'");
Review comment:
We can use `String.format` here.
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -2719,6 +2731,17 @@ private KVMPhysicalDisk
getPhysicalDiskPrimaryStore(PrimaryDataStoreTO primaryDa
return storagePool.getPhysicalDisk(data.getPath());
}
+ protected void setDiskIoDriver(DiskDef disk) {
+ /*
+ * IO Driver works for
+ * - Qemu >= 5.0
+ * - Libvirt >= 6.3.0
+ */
Review comment:
Instead of a comment, could we turn it into a javadoc for the method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
