sureshanaparti commented on a change in pull request #4977:
URL: https://github.com/apache/cloudstack/pull/4977#discussion_r636070874
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/storage/resource/VmwareStorageLayoutHelper.java
##########
@@ -168,12 +168,17 @@ public static String
syncVolumeToVmDefaultFolder(DatacenterMO dcMo, String vmNam
public static String syncVolumeToVmDefaultFolder(DatacenterMO dcMo, String
vmName, DatastoreMO ds, String vmdkName, String excludeFolders) throws
Exception {
assert (ds != null);
+
if (!ds.folderExists(String.format("[%s]", ds.getName()), vmName)) {
s_logger.info("VM folder does not exist on target datastore, we
will create one. vm: " + vmName + ", datastore: " + ds.getName());
-
ds.makeDirectory(String.format("[%s] %s", ds.getName(), vmName),
dcMo.getMor());
}
+ if (!ds.folderExists(String.format("[%s]", ds.getName()), "fcd")) {
Review comment:
> use the constant "HypervisorHostHelper.VSPHERE_DATASTORE_BASE_FOLDER"
for "_fcd_"
@skattoju4 any update on the changes suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
