rhtyd commented on a change in pull request #5017:
URL: https://github.com/apache/cloudstack/pull/5017#discussion_r638734452
##########
File path: engine/schema/src/main/java/com/cloud/vm/dao/VMInstanceDaoImpl.java
##########
@@ -613,7 +613,7 @@ boolean ifStateUnchanged(State oldState, State newState,
Long oldHostId, Long ne
if (backupOfferingId != null) {
sc.setParameters("backup_offering_id", backupOfferingId);
}
- return listBy(sc);
+ return listIncludingRemovedBy(sc);
Review comment:
The delete backup offering API will fail @Pearl1594 even though there
aren't any VMs assigned - could this be a regression?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
