rhtyd commented on a change in pull request #4631:
URL: https://github.com/apache/cloudstack/pull/4631#discussion_r638810660



##########
File path: tools/marvin/marvin/lib/base.py
##########
@@ -1521,12 +1513,12 @@ def _set_command(cls, apiclient, cmd, services, 
random_name=True):
             raise Exception(
                 "Unable to find Ostype is required for creating template")
 
-        cmd.snapshotid = snapshot.id
+        if volume:
+            cmd.volumeid = volume.id
+
+        if snapshot:
+            cmd.snapshotid = snapshot.id
 
-        if account:

Review comment:
       @slavkap dont' we need them anymore?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to