GutoVeronezi edited a comment on pull request #4585: URL: https://github.com/apache/cloudstack/pull/4585#issuecomment-850866396
@RodrigoDLopez @GabrielBrascher @DaanHoogland @sureshanaparti I'm pinging you here because you all reviewed PR [4586](https://github.com/apache/cloudstack/pull/4586). First I want to apologize for this inconvenience. This PR and [4586](https://github.com/apache/cloudstack/pull/4586) are some of my first PRs and I messed up they a little bit. Both PRs proposes differents changes, but they are linked by the new classes `AgentPropertiesFileHandler` and `AgentProperties`. These new classes were introducted in this PR and [4586](https://github.com/apache/cloudstack/pull/4586) was proposed based on it; I should have waited for this to be merged and then propose that. I marked [4586](https://github.com/apache/cloudstack/pull/4586) as draft and applied yours suggestions in this PR. Also I added unit tests to the handler. If it be merged, I will rebase [4586](https://github.com/apache/cloudstack/pull/4586). Could you review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
