GutoVeronezi commented on pull request #4585: URL: https://github.com/apache/cloudstack/pull/4585#issuecomment-851495871
> looks good, one question and one remark towards design; > q: properties are always read from file. Is that always what we want? > r: the use of the `AgentProperties<>` (plural) is to instantiate a single property. I think it makes sense to split the class in a container `AgentProperties`, and an element `AgentProperty<>` > > code looks good @DaanHoogland About the remark: As you suggested, `AgentProperties` now is a container of `AgentProperty<>`. I turned `AgentProperty<>` an inner class of `AgentProperties` to keep accessibility policy (private constructor). About the question: This PR intends to externalize the heartbeat timeout configuration on `KVMHAMonitor` via `agent.properties`; And the purpose of these classes is to retrieve the properties from file; So in the situation we are working, we always want the value from file. Is there any other situation that I should consider? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
