GutoVeronezi commented on pull request #4790:
URL: https://github.com/apache/cloudstack/pull/4790#issuecomment-851572175


   @sureshanaparti Thank you for this review. 
   
   As you suggested, I added the config to the validation in 
`ConfigurationManagerImpl`. However, I had to change the config type from 
`Double` to `Float` (not that it is a problem) because the validation only 
works on `Float` configs. 
   I tested some of they and realize that those with `Double` type are not 
validated. I think we need some refactors in this validation, in another PR. 
What do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to