weizhouapache commented on a change in pull request #5073:
URL: https://github.com/apache/cloudstack/pull/5073#discussion_r645490740
##########
File path: tools/appliance/systemvmtemplate/scripts/apt_upgrade.sh
##########
@@ -53,11 +53,17 @@ function apt_upgrade() {
rm -fv /root/*.iso
apt-get -q -y update
+
+ # Remove unused non-default kernel
apt-get -q -y upgrade
apt-get -q -y dist-upgrade
+ apt-get -q -y upgrade -t buster-backports
+ apt-get -q -y dist-upgrade -t buster-backports
+
apt-get -y autoremove --purge
apt-get autoclean
apt-get clean
+ reboot
}
Review comment:
@rhtyd might 'reboot' be an issue in packer processing ?
##########
File path: tools/appliance/systemvmtemplate/scripts/configure_grub.sh
##########
@@ -20,6 +20,8 @@ set -e
set -x
function configure_grub() {
+ # Remove old kernel
+ apt-get remove -y --purge linux-image-amd64 linux-image-4.19.0-16-amd64 ||
true
Review comment:
@rhtyd two potential issues in my opinion
(1) the versions are different in debian releases (debian 10.9.0: kernel
4.19.0.16.debian 10.8.0: kernel 4.19.0.14,etc)
(2) might there be more than 2 versions ? for example, one new kernel by
`apt-get -q -y dist-upgrade`, another new kernel by `apt-get -q -y dist-upgrade
-t buster-backports` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
