DaanHoogland commented on pull request #4585: URL: https://github.com/apache/cloudstack/pull/4585#issuecomment-856593942
> > > About the question: > > > This PR intends to externalize the heartbeat timeout configuration on `KVMHAMonitor` via `agent.properties`; And the purpose of these classes is to retrieve the properties from file; So in the situation we are working, we always want the value from file. > > > Is there any other situation that I should consider? > > > > > > I don't know but I could immagine there could be properties that require a restart on change and forbid a re-read from file. things like connection settings for instance. I am not sure. It was a legitimate question. > > @DaanHoogland It's a good use case. > In both cases, in some point of time, we will have to retrieve the property from the file; Maybe the question is when implement the call to `getPropertyValue`. `static final` would call it only once and, for example, in this PR, the method `getPropertyValue` is called once in constructor of `KVMHAMonitor`, which is instantiated only once in `LibvirtComputingResource.configure`. You are right and also, let's solve the issue when it really arises. this is good for now at least. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
