SadiJr commented on a change in pull request #5043:
URL: https://github.com/apache/cloudstack/pull/5043#discussion_r649109569
##########
File path:
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java
##########
@@ -3332,14 +3312,14 @@ public DiskOffering updateDiskOffering(final
UpdateDiskOfferingCmd cmd) {
}
/**
- * Check the tags parameters to the diskOffering
+ * Check the tags parameters to the disk/service offering
* <ul>
* <li>If tags is null, do nothing and return.</li>
- * <li>If tags is not null, set tag to the diskOffering.</li>
- * <li>If tags is an blank string, set null on diskOffering tag.</li>
+ * <li>If tags is not null, set tag to the disk/service offering.</li>
+ * <li>If tags is an blank string, set null on disk/service offering
tag.</li>
* </ul>
*/
- protected void updateDiskOfferingTagsIfIsNotNull(String tags,
DiskOfferingVO diskOffering) {
+ protected void updateOfferingTagsIfIsNotNull(String tags, DiskOfferingVO
diskOffering) {
if (tags == null) { return; }
if (StringUtils.isNotBlank(tags)) {
diskOffering.setTags(tags);
Review comment:
@slavkap for example, suppose you have the tags "tag1,tag2" saved and
you want to remove them. Ideally an empty string ("") would be sent, which
would remove the tags in the database in a similar way to the host tag
treatment in the updateServiceOfferingHostTagsIfNotNull method. However, this
type of scenario is not covered here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
