DK101010 commented on a change in pull request #4662:
URL: https://github.com/apache/cloudstack/pull/4662#discussion_r649735655
##########
File path:
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/guru/VmwareVmImplementer.java
##########
@@ -139,6 +140,9 @@ VirtualMachineTO implement(VirtualMachineProfile vm,
VirtualMachineTO to, long c
details.put(VmDetailConstants.NIC_ADAPTER,
VirtualEthernetCardType.E1000.toString());
}
}
+
if(StringUtils.isEmpty(details.get(VmDetailConstants.RAM_RESERVATION))){
+ details.put(VmDetailConstants.RAM_RESERVATION, "0.0");
Review comment:
Hi @GabrielBrascher, sorry for my late answer, I must have missed the
notification. I think there are no benefits regards reusable of this code, but
I agree it's better to use parameter instead of strings. I'm prefer your first
suggestion and will adapt it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
