Spaceman1984 commented on a change in pull request #4640:
URL: https://github.com/apache/cloudstack/pull/4640#discussion_r650803790



##########
File path: api/src/main/java/org/apache/cloudstack/api/BaseListCmd.java
##########
@@ -94,7 +94,7 @@ public Long getPageSizeVal() {
         if (pageSizeInt != null) {
             defaultPageSize = pageSizeInt.longValue();
         }
-        if (defaultPageSize.longValue() == s_pageSizeUnlimited) {
+        if (defaultPageSize!= null && defaultPageSize.longValue() == 
s_pageSizeUnlimited) {

Review comment:
       This is fine @DaanHoogland, this code came in as part of some unrelated 
merge. Not sure if we need something like: 
   
   if (s_pageSizeUnlimited.equals(defaultPageSize.longValue()) {
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to